jan/masque
1
1
Fork 0
Code Issues Pull requests Releases Wiki Activity

[ILibraryView] child_order shouldn't leak graphlib.CycleErrror

Browse source
This commit is contained in:
Jan Petykiewicz 2026-04-01 19:59:59 -07:00
commit ae314cce93
2 changed files with 28 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
masque/library.py
View file

@ -22,7 +22,7 @@ import copy
from pprint import pformat
from collections import defaultdict
from abc import ABCMeta, abstractmethod
from graphlib import TopologicalSorter
from graphlib import TopologicalSorter, CycleError
import numpy
from numpy.typing import ArrayLike, NDArray
@ -618,7 +618,13 @@ class ILibraryView(Mapping[str, 'Pattern'], metaclass=ABCMeta):
Return:
Topologically sorted list of pattern names.
"""
return cast('list[str]', list(TopologicalSorter(self.child_graph(dangling=dangling)).static_order()))
try:
return cast('list[str]', list(TopologicalSorter(self.child_graph(dangling=dangling)).static_order()))
except CycleError as exc:
cycle = exc.args[1] if len(exc.args) > 1 else None
if cycle is None:
raise LibraryError('Cycle found while building child order') from exc
raise LibraryError(f'Cycle found while building child order: {cycle}') from exc
def find_refs_local(
self,