Refactor runtime ownership and clean up warnings

This commit is contained in:
Jan Petykiewicz 2026-04-21 15:40:17 -07:00
commit 486b061558
628 changed files with 97954 additions and 90763 deletions

View file

@ -103,7 +103,7 @@ The same brush strip is tighter now too:
now as well, because it checks the per-node promotion-latch dword `[node+0x0c] == 1` rather than
reusing the queue kind field. `0x00438840` is the tiny
dispatch-or-fallback sibling: it forwards the currently active queue node at `[world+0x66aa]`
into `simulation_dispatch_runtime_effect_queue_record_by_kind_into_shell_or_world_handlers`
into `simulation_dispatch_runtime_effect_queue_node_by_kind`
`0x00437c00`, or opens the fixed custom modal rooted at localized id `0x153` when no active
node is staged.
company-credit side effect. One neighboring narrow counter is bounded too: `0x00422850`
@ -920,7 +920,7 @@ The same brush strip is tighter now too:
`[desc+0x24/+0x28]`, not an anonymous cargo-economy mode byte. Slot `34` `[0x006cec78+0x4b07]`
is similarly bounded
on the runtime side:
`world_run_company_start_or_city_connection_chooser_with_region_field_0x2d_temporarily_cleared_if_rule_0x4b07`
`world_try_publish_startup_company_or_city_connection_news_ignoring_territories`
`0x004013f0`, which sits immediately above the broader company-start or city-connection chooser
`0x00404ce0`, snapshots region dword `[entry+0x2d]` across all `0x18` live region records in
`0x006cfc9c`, zeros that field while the chooser runs, and then restores the original values on

View file

@ -2494,11 +2494,11 @@ Current evidence grounds the shell-controller-backed input and frame path as the
actual field-seeding layer beneath that allocator. The old unresolved higher placement chooser is
bounded more cleanly now too: the `0x00403ed5` and `0x0040446b` direct-placement commits sit
inside one larger helper,
`city_connection_try_build_route_with_optional_direct_site_placement` `0x00402cb0`. That shared
`city_connection_try_build_route_and_optionally_place_direct_site` `0x00402cb0`. That shared
heavy builder is now the common target of the compact wrapper `0x00404640`, the peer-route
candidate builder `0x004046a0`, the region-entry pair wrapper
`city_connection_try_build_route_between_region_entry_pair` `0x00404c60`, and the direct retry
paths inside `simulation_try_select_and_publish_company_start_or_city_connection_news`
paths inside `simulation_try_publish_startup_company_or_city_connection_news`
`0x00404ce0`. Internally it now has three bounded lanes:
an early route-entry search or synthesis attempt through
`route_entry_collection_try_build_path_between_optional_endpoint_entries` `0x004a01a0`,
@ -3830,11 +3830,11 @@ The low helper strip beneath that shared family is tighter now too: `0x0052ecd0`
against the scenario-side scale returned by `0x00437d20(index)` and rounds the result through
`0x005a10d0`.
The broader company-side owner above these pieces is tighter now too. The periodic service pass
`company_service_periodic_city_connection_finance_and_linked_transit_lanes` `0x004019e0` now
`company_service_periodic_city_connection_finance_and_linked_transit` `0x004019e0` now
reads as the current outer owner for this branch: it sequences the city-connection announcement
lanes, the linked-transit train-roster balancer, the acquisition-side sibling
`company_try_buy_unowned_industry_near_city_and_publish_news` `0x004014b0`, the annual finance-policy helper
`company_evaluate_annual_finance_policy_and_publish_news` `0x00401c50`, and the shorter-versus-
`company_try_acquire_unowned_industry_near_city_and_publish_news` `0x004014b0`, the annual finance-policy helper
`company_apply_annual_finance_policy_and_publish_news` `0x00401c50`, and the shorter-versus-
longer linked-transit cache refresh tail through `0x004093d0` and `0x00407bd0`. That outer pass
also has one tighter temporary-state role now: it clears company bytes `0x0d17/0x0d18/0x0d56`,
mirrors `0x0d17` into scenario field `0x006cec78+0x4c74` only while the earlier route-building
@ -3898,7 +3898,7 @@ The low helper strip beneath that shared family is tighter now too: `0x0052ecd0`
support-adjusted-share-price-times-factor-times-`1000`-times-`1.2` affordability gate before the
repeated `1000`-share buyback commits behind RT3.lng `2887`. The ordering above this helper is
tighter now too:
`company_service_periodic_city_connection_finance_and_linked_transit_lanes` clears those latches
`company_service_periodic_city_connection_finance_and_linked_transit` clears those latches
first, runs the city-connection and linked-transit branches, and only then enters the annual
finance helper, so these look like same-cycle reaction gates rather than long-lived balance-sheet
flags.

View file

@ -65,7 +65,7 @@ One reusable site helper is grounded now too.
before choosing whether a scanned site should carry `3871` `Connected By Another Company` or
`3872` `Already Connected by Another Company`. The larger caller boundary is no longer open
either: the first bounded announcement owner above this formatter family is now
`company_evaluate_and_publish_city_connection_bonus_news` at `0x00406050`, which re-enters the
`company_try_publish_city_connection_bonus_news` at `0x00406050`, which re-enters the
peer-route candidate builder at `0x004046a0` and later publishes one of the localized
city-connection bonus news strings `2888`, `2890`, or `2921` through the shell news path.
#### Peer-selector side
@ -88,7 +88,7 @@ The reusable bridge between the status formatter and the
`0x004046a0` reuses `city_connection_bonus_select_first_matching_peer_site` with both selector
flags forced on, rounds both the source-city and selected-peer normalized coordinates through
`0x005a10d0`, and then first tries the shared heavy builder
`city_connection_try_build_route_with_optional_direct_site_placement` `0x00402cb0` when the
`city_connection_try_build_route_and_optionally_place_direct_site` `0x00402cb0` when the
caller already supplied a live route-anchor tuple. When that direct attempt does not apply or no
peer survives, it falls back to the smaller wrapper
`city_connection_bonus_try_compact_route_builder_from_region_entry` `0x00404640`; and when both
@ -119,7 +119,7 @@ The reusable bridge between the status formatter and the
debt headline family, then publishes `2887` separately from the accumulated repurchased-share
count. The sibling news owner above the same
city-pair route family is bounded now too:
`simulation_try_select_and_publish_company_start_or_city_connection_news` `0x00404ce0`
`simulation_try_publish_startup_company_or_city_connection_news` `0x00404ce0`
filters and scores candidate city entries, re-enters the same shared heavy builder through
`city_connection_try_build_route_between_region_entry_pair` `0x00404c60` for the dense pair
sweep and the final retry, and then publishes `2889` `%1 has started a new company - the %2`