Simplify and speed up GDSII diffs
Summarize added and removed cells, group references, and keep replacement pairs together at text display limits. Trim hierarchy labels and summarize long unmatched paths. Stream JSON object evidence and reduce parsing and comparison allocations. Parse large revisions concurrently and adaptively reuse matching cell bodies when most of the layout is shared.
This commit is contained in:
parent
15e8a3b7b5
commit
8efeb04aab
1 changed files with 1137 additions and 261 deletions
230
tests/review.rs
230
tests/review.rs
|
|
@ -5,7 +5,9 @@ mod reports;
|
|||
use common::{library_header, record};
|
||||
use pheon::{
|
||||
records::*,
|
||||
review::{Comparison, Document, names::LAYER_SENTINEL},
|
||||
review::{
|
||||
Comparison, Document, TextComparison, names::LAYER_SENTINEL, selection::DisplayFilter,
|
||||
},
|
||||
};
|
||||
use std::{fs, path::PathBuf, process::Command};
|
||||
|
||||
|
|
@ -103,6 +105,19 @@ fn label(carrier: (u16, u16), text: &str) -> Vec<u8> {
|
|||
bytes
|
||||
}
|
||||
|
||||
fn path(width: Option<i32>, points: &[[i32; 2]]) -> Vec<u8> {
|
||||
let mut bytes = Vec::new();
|
||||
record(&mut bytes, RTAG_PATH, &[]);
|
||||
record(&mut bytes, RTAG_LAYER, &[0, 1]);
|
||||
record(&mut bytes, RTAG_DATATYPE, &[0, 0]);
|
||||
if let Some(width) = width {
|
||||
record(&mut bytes, RTAG_WIDTH, &width.to_be_bytes());
|
||||
}
|
||||
xy(&mut bytes, points);
|
||||
record(&mut bytes, RTAG_ENDEL, &[]);
|
||||
bytes
|
||||
}
|
||||
|
||||
fn with_property(mut object: Vec<u8>, value: &str) -> Vec<u8> {
|
||||
object.truncate(object.len() - 4);
|
||||
record(&mut object, RTAG_PROPATTR, &17_u16.to_be_bytes());
|
||||
|
|
@ -500,9 +515,9 @@ fn shared_hierarchy_reports_ancestors_and_marks_repeated_definitions() {
|
|||
"Hierarchy\n",
|
||||
"\"CHIP\" [affected]\n",
|
||||
" \"left\" x1 [affected]\n",
|
||||
" \"leaf\" x2 [cell changed]\n",
|
||||
" \"leaf\" x2 [changed]\n",
|
||||
" \"right\" x1 [affected]\n",
|
||||
" \"leaf\" x3 [cell changed] [shown above]\n",
|
||||
" \"leaf\" x3 [changed] [shown above]\n",
|
||||
)
|
||||
);
|
||||
let graph = diff.hierarchy(true, 8);
|
||||
|
|
@ -524,11 +539,12 @@ fn reference_changes_keep_unchanged_targets_and_old_edges_visible() {
|
|||
let new = Document::parse(&pair.new).unwrap();
|
||||
let diff = Comparison::between(&old, &new);
|
||||
let tree = diff.hierarchy(false, 8);
|
||||
assert!(tree.contains("[cell unchanged]"), "{tree}");
|
||||
assert!(tree.contains("[reference changed]"), "{tree}");
|
||||
if pair.name == "array count" {
|
||||
assert!(tree.contains("x2 -> x3"), "{tree}");
|
||||
}
|
||||
let edge = if pair.name == "array count" {
|
||||
" \"leaf\" x2 -> x3\n"
|
||||
} else {
|
||||
" \"leaf\" x1 [reference changed]\n"
|
||||
};
|
||||
assert!(tree.ends_with(edge), "{tree}");
|
||||
}
|
||||
let a = layout(&[
|
||||
("CHIP", vec![reference("leaf", 0, 1)]),
|
||||
|
|
@ -537,14 +553,19 @@ fn reference_changes_keep_unchanged_targets_and_old_edges_visible() {
|
|||
let b = layout(&[("CHIP", vec![])]);
|
||||
let a = Document::parse(&a).unwrap();
|
||||
let b = Document::parse(&b).unwrap();
|
||||
let tree = Comparison::between(&a, &b).hierarchy(false, 8);
|
||||
assert!(tree.contains("\"leaf\" x1 -> x0"), "{tree}");
|
||||
for (old, new, edge) in [
|
||||
(&a, &b, " \"leaf\" x1 -> x0 [removed]\n"),
|
||||
(&b, &a, " \"leaf\" x0 -> x1 [added]\n"),
|
||||
] {
|
||||
let tree = Comparison::between(old, new).hierarchy(false, 8);
|
||||
assert!(tree.ends_with(edge), "{tree}");
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn same_bounds_changes_and_truncated_reports_remain_differences() {
|
||||
let a = layout(&[("CHIP", vec![square()])]);
|
||||
let b = layout(&[("CHIP", vec![triangle()])]);
|
||||
let b = layout(&[("CHIP", vec![triangle(), label((2, 0), "new label")])]);
|
||||
let a = Document::parse(&a).unwrap();
|
||||
let b = Document::parse(&b).unwrap();
|
||||
let diff = Comparison::between(&a, &b);
|
||||
|
|
@ -552,7 +573,10 @@ fn same_bounds_changes_and_truncated_reports_remain_differences() {
|
|||
diff.cells[0].removed[0].bounds,
|
||||
diff.cells[0].added[0].bounds
|
||||
);
|
||||
assert!(diff.text(0).contains("Showing 0 of 2 object changes"));
|
||||
let limited = diff.text(1);
|
||||
assert!(limited.contains("Omitted · 2 object changes over the limit"));
|
||||
assert!(limited.contains("+ 2/0: label"));
|
||||
assert!(!limited.contains("1/0:"));
|
||||
assert_eq!(diff.outcome().exit_code(), 1);
|
||||
assert!(diff.cells[0].removed[0].offset > 0);
|
||||
}
|
||||
|
|
@ -586,6 +610,7 @@ fn unit_changes_report_values_without_claiming_geometry_equivalence() {
|
|||
assert!(text.contains("Coordinates use each file's database units"));
|
||||
assert!(!text.contains("raw="));
|
||||
assert!(diff.cells.is_empty());
|
||||
assert!(diff.hierarchy(false, 8).is_empty());
|
||||
}
|
||||
|
||||
#[test]
|
||||
|
|
@ -712,7 +737,13 @@ fn cli_uses_documented_exit_codes_and_accepts_paths_with_spaces() {
|
|||
fs::write(&old, shared(square())).unwrap();
|
||||
fs::write(&new, shared(triangle())).unwrap();
|
||||
let command = || Command::new(env!("CARGO_BIN_EXE_pheon"));
|
||||
let equal = command().arg("diff").arg(&old).arg(&old).output().unwrap();
|
||||
let equal = command()
|
||||
.arg("diff")
|
||||
.arg(&old)
|
||||
.arg(&old)
|
||||
.args(["--hierarchy", "ascii"])
|
||||
.output()
|
||||
.unwrap();
|
||||
assert_eq!(equal.status.code(), Some(0));
|
||||
assert_eq!(equal.stdout, b"Equal\n");
|
||||
let diff = command()
|
||||
|
|
@ -724,7 +755,7 @@ fn cli_uses_documented_exit_codes_and_accepts_paths_with_spaces() {
|
|||
.unwrap();
|
||||
assert_eq!(diff.status.code(), Some(1));
|
||||
let text = String::from_utf8(diff.stdout).unwrap();
|
||||
assert!(text.contains("Showing 0 of 2 object changes"));
|
||||
assert!(text.contains("Omitted · 2 object changes over the limit"));
|
||||
assert!(text.contains("Hierarchy\n```mermaid\nflowchart TD"));
|
||||
assert!(!text.contains("scope top=all"));
|
||||
let dump = command()
|
||||
|
|
@ -1105,9 +1136,9 @@ fn display_filters_never_change_equality_or_totals() {
|
|||
layer: Some((42, 0)),
|
||||
},
|
||||
);
|
||||
assert!(text.starts_with("Different · 1 changed cell · 1 removed, 1 added\n"));
|
||||
assert!(text.starts_with("Different · 1 cell modified\n"));
|
||||
assert!(text.contains("Display filter layer=42/0\n"));
|
||||
assert!(text.contains("Showing 0 of 2 object changes (2 filtered out)"));
|
||||
assert!(text.contains("Omitted · 2 object changes filtered out"));
|
||||
assert!(!text.contains("cell \"CHIP\""));
|
||||
assert_eq!(diff.outcome().exit_code(), 1);
|
||||
}
|
||||
|
|
@ -1133,12 +1164,13 @@ fn text_hides_empty_headings_and_counts_filtered_and_limited_changes() {
|
|||
]);
|
||||
let diff = Comparison::between(&Document::parse(&a).unwrap(), &Document::parse(&b).unwrap());
|
||||
let text = diff.text(0);
|
||||
assert!(text.starts_with("Different · 3 cells modified, 2 added, 1 removed\n"));
|
||||
assert!(text.contains("cell \"gone\" (removed, 2 objects)\n"));
|
||||
assert!(text.contains("cell \"new\" (added, 1 object)\n"));
|
||||
assert!(text.contains("cell \"empty\" (added, 0 objects)\n"));
|
||||
assert!(text.contains("cell \"header\" (attributes changed)\n"));
|
||||
assert!(!text.contains("cell \"changed\""));
|
||||
assert!(text.contains("Showing 0 of 7 object changes (7 over the limit)"));
|
||||
assert!(text.contains("Omitted · 4 object changes over the limit"));
|
||||
|
||||
let text = diff.text_filtered(
|
||||
1,
|
||||
|
|
@ -1149,21 +1181,25 @@ fn text_hides_empty_headings_and_counts_filtered_and_limited_changes() {
|
|||
);
|
||||
assert!(text.contains(concat!(
|
||||
"Display filter cell=\"changed\" layer=1/0\n",
|
||||
"Showing 1 of 7 object changes (5 filtered out, 1 over the limit)\n",
|
||||
"4 cell-level changes filtered out\n",
|
||||
"cell \"changed\"\n 1/0: 1 rectangle removed",
|
||||
"Omitted · 2 object changes filtered out · 2 object changes over the limit",
|
||||
" · 4 cell-level changes filtered out\n",
|
||||
)));
|
||||
assert!(!text.contains("cell \"changed\""));
|
||||
assert!(!text.contains("cell \"other\""));
|
||||
assert!(!text.contains("cell \"new\""));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn reference_summaries_group_whole_cells_and_keep_full_placements_in_dumps() {
|
||||
fn reference_summaries_group_repeated_targets_and_keep_full_placements_in_dumps() {
|
||||
let empty = layout(&[("leaf", vec![]), ("other", vec![])]);
|
||||
let with_chip = layout(&[
|
||||
(
|
||||
"CHIP",
|
||||
vec![
|
||||
square(),
|
||||
label((2, 0), "chip label"),
|
||||
label((900, 7), LAYER_SENTINEL),
|
||||
label((900, 7), "3:0:WG"),
|
||||
reference("leaf", 0, 1),
|
||||
reference("leaf", 5, 1),
|
||||
reference("leaf", 2, 2),
|
||||
|
|
@ -1178,21 +1214,60 @@ fn reference_summaries_group_whole_cells_and_keep_full_placements_in_dumps() {
|
|||
let with_chip = Document::parse(&with_chip).unwrap();
|
||||
let existing_chip = Document::parse(&existing_chip).unwrap();
|
||||
|
||||
for (old, new, sign) in [(&empty, &with_chip, "+"), (&with_chip, &empty, "-")] {
|
||||
for (old, new, action, sign) in [
|
||||
(&empty, &with_chip, "added", "+"),
|
||||
(&with_chip, &empty, "removed", "-"),
|
||||
] {
|
||||
let diff = Comparison::between(old, new);
|
||||
let text_diff = TextComparison::between(old, new);
|
||||
let text = diff.text(100);
|
||||
assert!(text.contains(&format!("cell \"CHIP\" ({action}, 6 objects)\n")));
|
||||
assert!(text.contains(&format!(
|
||||
" {sign} 2 references, 1 array reference to \"leaf\" (4 placements)\n"
|
||||
)));
|
||||
assert!(text.contains(&format!(" {sign} 1 reference to \"other\"\n")));
|
||||
assert!(!text.contains("xy="));
|
||||
assert!(!text.contains("1/0"));
|
||||
assert!(!text.contains("2/0"));
|
||||
assert!(!text.contains("Omitted"));
|
||||
let limited = diff.text(2);
|
||||
assert!(limited.contains(&format!(" {sign} 2 references to \"leaf\"\n")));
|
||||
assert!(limited.contains("Showing 2 of 4 object changes (2 over the limit)"));
|
||||
assert!(limited.contains("Omitted · 2 object changes over the limit"));
|
||||
assert_eq!(text_diff.outcome(), diff.outcome());
|
||||
for mermaid in [false, true] {
|
||||
assert_eq!(text_diff.hierarchy(mermaid, 8), diff.hierarchy(mermaid, 8));
|
||||
}
|
||||
for show in [
|
||||
DisplayFilter::default(),
|
||||
DisplayFilter {
|
||||
cell: Some("other".into()),
|
||||
layer: None,
|
||||
},
|
||||
DisplayFilter {
|
||||
cell: None,
|
||||
layer: Some((1, 0)),
|
||||
},
|
||||
] {
|
||||
for max in [0, 2, 100] {
|
||||
assert_eq!(
|
||||
text_diff.render_text(max, &show, true),
|
||||
diff.text_filtered(max, &show)
|
||||
);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
let text = Comparison::between(&existing_chip, &with_chip).text(100);
|
||||
assert!(text.contains(" + reference \"leaf\" xy=(0, 0)\n"));
|
||||
for (old, new, sign) in [
|
||||
(&existing_chip, &with_chip, "+"),
|
||||
(&with_chip, &existing_chip, "-"),
|
||||
] {
|
||||
let text = Comparison::between(old, new).text(100);
|
||||
assert!(text.contains(&format!(
|
||||
" {sign} 2 references, 1 array reference to \"leaf\" (4 placements)\n"
|
||||
)));
|
||||
assert!(!text.contains("\"leaf\" xy="));
|
||||
assert!(text.contains(&format!(" {sign} reference \"other\" xy=(10, 0)\n")));
|
||||
}
|
||||
let dump = with_chip.canonical_dump();
|
||||
assert!(dump.contains(" reference \"leaf\" xy=(5, 0)\n"));
|
||||
assert!(dump.contains(" array reference \"leaf\" (2 × 1) xy=[(2, 0), (102, 0), (2, 0)]\n"));
|
||||
|
|
@ -1265,7 +1340,7 @@ fn git_external_driver_handles_changes_additions_deletions_and_errors() {
|
|||
assert!(
|
||||
String::from_utf8(changed.stdout)
|
||||
.unwrap()
|
||||
.contains("Different · 1 changed cell · 1 removed, 1 added")
|
||||
.contains("Different · 1 cell modified\n")
|
||||
);
|
||||
fs::write(&path, b"invalid").unwrap();
|
||||
let invalid = Command::new("git")
|
||||
|
|
@ -1278,23 +1353,34 @@ fn git_external_driver_handles_changes_additions_deletions_and_errors() {
|
|||
assert!(!invalid.status.success());
|
||||
assert!(String::from_utf8_lossy(&invalid.stderr).contains("pheon:"));
|
||||
fs::write(&path, layout(&[("CHIP", vec![square()])])).unwrap();
|
||||
let mode_change = Command::new(env!("CARGO_BIN_EXE_pheon"))
|
||||
.args(["git-diff", "--hierarchy", "ascii", "--", "chip layout.gds"])
|
||||
.arg(&path)
|
||||
.args(["old", "100644"])
|
||||
.arg(&path)
|
||||
.args(["new", "100755"])
|
||||
.output()
|
||||
.unwrap();
|
||||
assert!(mode_change.status.success());
|
||||
assert_eq!(
|
||||
mode_change.stdout,
|
||||
b"layout \"chip layout.gds\"\nmode \"100644\" -> \"100755\"\nEqual\n"
|
||||
);
|
||||
let added = directory.join("added layout.gds");
|
||||
fs::write(&added, shared(square())).unwrap();
|
||||
git(&["add", "added layout.gds"]);
|
||||
let result = git(&["diff", "--cached", "--", "added layout.gds"]);
|
||||
assert!(
|
||||
String::from_utf8(result.stdout)
|
||||
.unwrap()
|
||||
.contains("layout added")
|
||||
);
|
||||
let text = String::from_utf8(result.stdout).unwrap();
|
||||
assert!(text.starts_with("layout \"added layout.gds\" added\nDifferent · 4 cells added\n"));
|
||||
assert!(!text.contains("\nmode "));
|
||||
assert!(!text.contains("\nlibrary "));
|
||||
fs::remove_file(&path).unwrap();
|
||||
git(&["add", "-u"]);
|
||||
let result = git(&["diff", "--cached", "--", "chip layout.gds"]);
|
||||
assert!(
|
||||
String::from_utf8(result.stdout)
|
||||
.unwrap()
|
||||
.contains("layout deleted")
|
||||
);
|
||||
let text = String::from_utf8(result.stdout).unwrap();
|
||||
assert!(text.starts_with("layout \"chip layout.gds\" deleted\nDifferent · 1 cell removed\n"));
|
||||
assert!(!text.contains("\nmode "));
|
||||
assert!(!text.contains("\nlibrary "));
|
||||
// Textconv is an alternative to the external driver, with a separate cache.
|
||||
git(&["commit", "-qm", "replace fixture"]);
|
||||
git(&["mv", "added layout.gds", "renamed layout.gds"]);
|
||||
|
|
@ -1304,10 +1390,7 @@ fn git_external_driver_handles_changes_additions_deletions_and_errors() {
|
|||
let result = git(&["diff", "--cached", "--find-renames"]);
|
||||
let text = String::from_utf8(result.stdout).unwrap();
|
||||
assert!(text.contains("renamed layout.gds"), "{text}");
|
||||
assert!(
|
||||
text.contains("Different · 1 changed cell · 1 removed, 1 added"),
|
||||
"{text}"
|
||||
);
|
||||
assert!(text.contains("Different · 1 cell modified\n"), "{text}");
|
||||
git(&["commit", "-qm", "rename fixture"]);
|
||||
fs::write(directory.join(".gitattributes"), "*.gds diff=pheon-text\n").unwrap();
|
||||
fs::write(&renamed, shared(square())).unwrap();
|
||||
|
|
@ -1348,7 +1431,10 @@ fn replacement_explanations_are_unique_and_keep_full_evidence() {
|
|||
assert!(!text.contains(" + "));
|
||||
assert!(!text.contains("bbox="));
|
||||
assert!(!diff.text(0).contains(" ~ "));
|
||||
assert!(diff.text(1).contains("Showing 1 of 2 object changes"));
|
||||
assert_eq!(
|
||||
diff.text(1),
|
||||
"Different · 1 cell modified\nOmitted · 2 object changes over the limit\n"
|
||||
);
|
||||
}
|
||||
let a = layout(&[("CHIP", vec![square(), square()])]);
|
||||
let b = layout(&[("CHIP", vec![triangle(), triangle()])]);
|
||||
|
|
@ -1440,7 +1526,7 @@ fn polygon_diff_groups_shapes_by_layer_across_dimensions() {
|
|||
assert_eq!(
|
||||
diff.text(100),
|
||||
concat!(
|
||||
"Different · 1 changed cell · 4 removed, 4 added\n",
|
||||
"Different · 1 cell modified\n",
|
||||
"cell \"CHIP\"\n",
|
||||
" 1/0: 2 rectangles, 1 polygon changed\n",
|
||||
" 2/0: 1 polygon changed\n",
|
||||
|
|
@ -1463,20 +1549,9 @@ fn polygon_diff_distinguishes_boxes_from_rectangular_boundaries() {
|
|||
|
||||
#[test]
|
||||
fn path_width_explanation_preserves_absent_and_zero() {
|
||||
let path = |width: Option<i32>| {
|
||||
let mut bytes = Vec::new();
|
||||
record(&mut bytes, RTAG_PATH, &[]);
|
||||
record(&mut bytes, RTAG_LAYER, &[0, 1]);
|
||||
record(&mut bytes, RTAG_DATATYPE, &[0, 0]);
|
||||
if let Some(n) = width {
|
||||
record(&mut bytes, RTAG_WIDTH, &n.to_be_bytes());
|
||||
}
|
||||
xy(&mut bytes, &[[0, 0], [10, 10]]);
|
||||
record(&mut bytes, RTAG_ENDEL, &[]);
|
||||
layout(&[("CHIP", vec![bytes])])
|
||||
};
|
||||
let a = path(None);
|
||||
let b = path(Some(0));
|
||||
let points = [[0, 0], [10, 10]];
|
||||
let a = layout(&[("CHIP", vec![path(None, &points)])]);
|
||||
let b = layout(&[("CHIP", vec![path(Some(0), &points)])]);
|
||||
let diff = Comparison::between(&Document::parse(&a).unwrap(), &Document::parse(&b).unwrap());
|
||||
assert!(
|
||||
diff.text(100)
|
||||
|
|
@ -1484,6 +1559,43 @@ fn path_width_explanation_preserves_absent_and_zero() {
|
|||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn unmatched_paths_summarize_coordinates_that_would_wrap() {
|
||||
let points = [[0, 0], [4, 0], [4, -5], [13, -5], [13, 9]];
|
||||
let empty = layout(&[("CHIP", vec![])]);
|
||||
let paths = layout(&[(
|
||||
"CHIP",
|
||||
vec![
|
||||
path(None, &points),
|
||||
path(Some(-8), &points),
|
||||
path(Some(0), &points[..4]),
|
||||
],
|
||||
)]);
|
||||
let empty = Document::parse(&empty).unwrap();
|
||||
let paths = Document::parse(&paths).unwrap();
|
||||
for (old, new, sign) in [(&empty, &paths, "+"), (&paths, &empty, "-")] {
|
||||
let text = Comparison::between(old, new).text(100);
|
||||
for width in ["absent", "-8 dbu"] {
|
||||
assert!(text.contains(&format!(
|
||||
" {sign} 1/0: path · width {width} · 5 vertices · bounds (0, -5) to (13, 9) dbu\n"
|
||||
)));
|
||||
}
|
||||
assert_eq!(text.lines().count(), 5, "{text}");
|
||||
assert!(text.contains("xy=[(0, 0), (4, 0), (4, -5), (13, -5)]"));
|
||||
}
|
||||
assert!(paths.canonical_dump().contains("\n (13, 9)]"));
|
||||
let report =
|
||||
Comparison::between(&empty, &paths).json_report(&Default::default(), &Default::default());
|
||||
assert!(
|
||||
report["cell_changes"][0]["added"]
|
||||
.as_array()
|
||||
.unwrap()
|
||||
.iter()
|
||||
.flat_map(|object| object["fields"].as_array().unwrap())
|
||||
.any(|field| field["tag"] == RTAG_XY && field["value"] == serde_json::json!(points))
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn label_replacements_show_only_changed_fields() {
|
||||
let a = layout(&[("CHIP", vec![label((2, 0), "old")])]);
|
||||
|
|
@ -1491,7 +1603,7 @@ fn label_replacements_show_only_changed_fields() {
|
|||
let diff = Comparison::between(&Document::parse(&a).unwrap(), &Document::parse(&b).unwrap());
|
||||
assert_eq!(
|
||||
diff.text(100),
|
||||
"Different · 1 changed cell · 1 removed, 1 added\ncell \"CHIP\"\n ~ 2/0: label text \"old\" -> \"new\"\n"
|
||||
"Different · 1 cell modified\ncell \"CHIP\"\n ~ 2/0: label text \"old\" -> \"new\"\n"
|
||||
);
|
||||
}
|
||||
|
||||
|
|
@ -1536,6 +1648,10 @@ fn library_presence_changes_distinguish_empty_and_absent_revisions() {
|
|||
assert_eq!(added.outcome().exit_code(), 1);
|
||||
assert!(added.text(0).contains("library added\n"));
|
||||
assert!(added.text(0).starts_with("Different · 1 library change\n"));
|
||||
assert_eq!(
|
||||
added.render_text(0, &Default::default(), false),
|
||||
"Different\n"
|
||||
);
|
||||
let removed = Comparison::between(&doc, &absent);
|
||||
assert_eq!(removed.outcome().exit_code(), 1);
|
||||
assert!(removed.text(0).contains("library removed\n"));
|
||||
|
|
|
|||
Loading…
Reference in a new issue