From 35fc67faa3cbc9892abfbbe2a4e9f53bcfa53f77 Mon Sep 17 00:00:00 2001 From: Forgejo Actions Date: Wed, 22 Apr 2026 21:08:12 -0700 Subject: [PATCH] [compute_overlap_e] remove omega arg (unused) --- examples/waveguide.py | 2 +- meanas/fdfd/waveguide_3d.py | 1 - meanas/test/test_waveguide_fdtd_fdfd.py | 4 ---- meanas/test/test_waveguide_mode_helpers.py | 4 ---- 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/examples/waveguide.py b/examples/waveguide.py index 7becd59..f243924 100644 --- a/examples/waveguide.py +++ b/examples/waveguide.py @@ -100,7 +100,7 @@ def get_waveguide_mode( # compute_overlap_e() returns the normalized upstream overlap window used to # project another field onto this same guided mode. - e_overlap = waveguide_3d.compute_overlap_e(E=wg_results['E'], wavenumber=wg_results['wavenumber'], **wg_args, omega=omega) + e_overlap = waveguide_3d.compute_overlap_e(E=wg_results['E'], wavenumber=wg_results['wavenumber'], **wg_args) return J, e_overlap diff --git a/meanas/fdfd/waveguide_3d.py b/meanas/fdfd/waveguide_3d.py index 01db9b1..c77c8d4 100644 --- a/meanas/fdfd/waveguide_3d.py +++ b/meanas/fdfd/waveguide_3d.py @@ -196,7 +196,6 @@ def compute_overlap_e( axis: int, polarity: int, slices: Sequence[slice], - _omega: float, ) -> cfdfield_t: r""" Build an overlap field for projecting another 3D electric field onto a mode. diff --git a/meanas/test/test_waveguide_fdtd_fdfd.py b/meanas/test/test_waveguide_fdtd_fdfd.py index ad9a4e6..0488197 100644 --- a/meanas/test/test_waveguide_fdtd_fdfd.py +++ b/meanas/test/test_waveguide_fdtd_fdfd.py @@ -380,7 +380,6 @@ def _run_straight_waveguide_case(variant: str) -> WaveguideCalibrationResult: axis=0, polarity=1, slices=MONITOR_SLICES, - omega=OMEGA, # type: ignore[call-arg] ) update_e, update_h = fdtd.updates_with_cpml(cpml_params=_build_cpml_params(), dt=DT, dxes=base_dxes, epsilon=epsilon) @@ -488,7 +487,6 @@ def _run_width_step_scattering_case() -> WaveguideScatteringResult: axis=0, polarity=-1, slices=SCATTERING_REFLECT_SLICES, - omega=OMEGA, # type: ignore[call-arg] ) transmitted_mode = waveguide_3d.solve_mode( 0, @@ -506,7 +504,6 @@ def _run_width_step_scattering_case() -> WaveguideScatteringResult: axis=0, polarity=1, slices=SCATTERING_TRANSMIT_SLICES, - omega=OMEGA, # type: ignore[call-arg] ) update_e, update_h = fdtd.updates_with_cpml(cpml_params=_build_cpml_params(), dt=DT, dxes=base_dxes, epsilon=epsilon) @@ -621,7 +618,6 @@ def _run_pulsed_straight_waveguide_case() -> PulsedWaveguideCalibrationResult: axis=0, polarity=1, slices=MONITOR_SLICES, - omega=OMEGA, # type: ignore[call-arg] ) update_e, update_h = fdtd.updates_with_cpml(cpml_params=_build_cpml_params(), dt=DT, dxes=base_dxes, epsilon=epsilon, dtype=complex) diff --git a/meanas/test/test_waveguide_mode_helpers.py b/meanas/test/test_waveguide_mode_helpers.py index 162c634..d3ec7cd 100644 --- a/meanas/test/test_waveguide_mode_helpers.py +++ b/meanas/test/test_waveguide_mode_helpers.py @@ -100,7 +100,6 @@ def test_waveguide_3d_compute_overlap_e_uses_adjacent_window( axis=0, polarity=polarity, slices=slices, - omega=OMEGA, # type: ignore[call-arg] ) nonzero = numpy.argwhere(numpy.abs(overlap) > 0) @@ -130,7 +129,6 @@ def test_waveguide_3d_compute_overlap_e_warns_when_window_is_clipped( axis=0, polarity=polarity, slices=slices, - omega=OMEGA, # type: ignore[call-arg] ) nonzero = numpy.argwhere(numpy.abs(overlap) > 0) @@ -158,7 +156,6 @@ def test_waveguide_3d_compute_overlap_e_rejects_empty_overlap_window( axis=0, polarity=polarity, slices=slices, - omega=OMEGA, # type: ignore[call-arg] ) @@ -173,7 +170,6 @@ def test_waveguide_3d_compute_overlap_e_rejects_zero_support_window() -> None: axis=0, polarity=1, slices=slices, - omega=OMEGA, # type: ignore[call-arg] )